test: use Node.js mock instead of esmock package#488
Merged
fraxken merged 1 commit intoNodeSecure:masterfrom May 26, 2025
Merged
test: use Node.js mock instead of esmock package#488fraxken merged 1 commit intoNodeSecure:masterfrom
fraxken merged 1 commit intoNodeSecure:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #488 +/- ##
============================================
- Coverage 100.00% 83.60% -16.40%
============================================
Files 15 29 +14
Lines 649 1952 +1303
Branches 0 1 +1
============================================
+ Hits 649 1632 +983
- Misses 0 320 +320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Hmm not sure why but one test is failing on ubuntu |
Contributor
Author
|
I've searched but I can't find it. Indeed on ubuntu, the mock doesn't work inside the 'open' package ¯\(ツ)/¯. |
fraxken
approved these changes
May 26, 2025
Member
|
@allcontributors please add @Dafyh for test |
Contributor
|
I've put up a pull request to add @Dafyh! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#444